Should I disassemble my lock before applying a metal darkening product like Jax's?

Yes, it is best to take the lock apart before using a product like Jax's, because the product can get into places like screw threads where it should not be and cause corrosion over time if left on an assembled lock.